CI - C# quickstart test properly uses nuget#3466
Merged
Conversation
bfops
commented
Oct 23, 2025
bfops
changed the title
rekhoff
approved these changes
Oct 23, 2025
Contributor
rekhoff
left a comment
rekhoff
left a comment
There was a problem hiding this comment.
Looks good. I like the reuse of the override_nuget_package for each of the nuget packages that need to get imported. And the sequence that it does makes sense too. Approved.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The quickstart smoketest was not correctly fudging our NuGet dependencies to use the local versions of the packages, so it was pulling them from NuGet. This ended up causing issues when we tried to modify local packages and then use them in a way that affected the quickstart (e.g. #3386).
We had a few issues: we weren't ensuring that the local packages were built, we weren't using the right directory for those packages, and we weren't adding a "package source mapping" that forced those packages to be used from the local directory.
API and ABI breaking changes
None. CI-only.
Expected complexity level and risk
2
Testing