Skip to content

Docusaurus migration#3343

Merged
JulienLavocat merged 54 commits intomasterfrom
docusaurus-migration
Oct 24, 2025
Merged

Docusaurus migration#3343
JulienLavocat merged 54 commits intomasterfrom
docusaurus-migration

Conversation

@JulienLavocat
Copy link
Contributor

@JulienLavocat JulienLavocat commented Oct 3, 2025

Description of Changes

  • Migrate the documentation site to Docusaurus.
  • Add a GitHub Action workflow that runs pnpm build on pull requests targeting master.
    This command checks for broken links and images and ensures the site builds correctly.
  • Add a GitHub Action workflow to publish the docs automatically when a merge occurs on the docs/release branch.

Important: The workflows haven't been tested yet due to the fact that they need to be merged first before being able to run. It's a fairly basic workflow I don't expect this to block anyone but anyways I will make another PR with the complete changes when I can actually run it.


API and ABI Breaking Changes

No breaking changes for SpacetimeDB users.
Documentation contributors should experience minimal disruption — content is still written in Markdown.


Expected Complexity Level and Risk

Complexity: 3/5

Reasons:

  1. Several adjustments were made to fit Docusaurus conventions:

    • Replaced our custom :::server-rust blocks with Docusaurus <Tabs/> components.
    • Converted “Note” callouts using admonitions instead of Markdown blockquotes.
    • Updated all images (including Unity tutorial ones, which were previously commented out).
    • Moved images from the DO bucket into the repository at docs/static/images.
  2. Customized Docusaurus CSS and one component to apply our theme and color palette.


Testing

Tested locally.


Review Notes

This PR involves many file changes — a full code review is likely not productive.
Instead, please focus on verifying that the documentation content was migrated correctly:

  • Review sections you’re familiar with to confirm accuracy.
  • Ensure formatting, links, and images render as expected.

You can follow the updated README for instructions on running Docusaurus locally.

@JulienLavocat JulienLavocat force-pushed the docusaurus-migration branch 2 times, most recently from fbd26f2 to aa7cca6 Compare October 6, 2025 12:01
@bfops bfops added release-any To be landed in any release window no runtime change This change does not affect the final binaries labels Oct 6, 2025
@JulienLavocat JulienLavocat force-pushed the docusaurus-migration branch 7 times, most recently from 46c21ab to f590ae0 Compare October 8, 2025 10:30
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question on this one so far, otherwise the rest of the edits look good to me

@JasonAtClockwork
Copy link
Contributor

JasonAtClockwork commented Oct 8, 2025

I've reviewed the entire Unreal tutorial and it looks 100% (all links, code and images), the only thing is it looks like new version is missing the Unreal Reference from the Client SDK:

New:
Image

Old:
Image

Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder that I still needed to run this command in order to get the docs rendering:

pnpm add @docusaurus/theme-common

Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed a majority of the documentation and I think it looks good. There are just 2 issues to fix here I think:

  1. Fix the issue with having to manually install @docusaurus/theme-common
  2. Fix the code formatting issues in the Unity tutorial

besides that I think this is ready to go. Let me know when you want me to take another look 👍

@JulienLavocat JulienLavocat force-pushed the docusaurus-migration branch 3 times, most recently from 0892495 to 9f04566 Compare October 10, 2025 09:35
@JulienLavocat
Copy link
Contributor Author

the only thing is it looks like new version is missing the Unreal Reference from the Client SDK:
Added @JasonAtClockwork

@JasonAtClockwork
Copy link
Contributor

the only thing is it looks like new version is missing the Unreal Reference from the Client SDK:
Added @JasonAtClockwork

Looks great! All the Unreal stuff is complete.

Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more formatting issues here

@JulienLavocat JulienLavocat force-pushed the docusaurus-migration branch 2 times, most recently from 42faabf to 8050d6b Compare October 15, 2025 09:44
Copy link
Contributor

@JasonAtClockwork JasonAtClockwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Unreal work looks great!

@JulienLavocat JulienLavocat added this pull request to the merge queue Oct 24, 2025
Merged via the queue into master with commit afb8c08 Oct 24, 2025
24 of 25 checks passed
gefjon added a commit that referenced this pull request Nov 26, 2025
Somehow (apparently after #3494) we wound up with a bunch of duplicate folders in our repo,
both the old title-case names and the new lower-case names.
All of the remaining files in the title-case directories
have their last change in #3343, well before #3494,
so I don't believe we're losing any intermediate changes by deleting them.
I'm not sure how this happened, but it seems to be an easy fix.
github-merge-queue bot pushed a commit that referenced this pull request Nov 26, 2025
# Description of Changes

Somehow (apparently after #3494) we wound up with a bunch of duplicate
folders in our repo, both the old title-case names and the new
lower-case names. All of the remaining files in the title-case
directories have their last change in #3343, well before #3494, so I
don't believe we're losing any intermediate changes by deleting them.
I'm not sure how this happened, but it seems to be an easy fix.


# API and ABI breaking changes

N/a

# Expected complexity level and risk

2 - some small possibility that I accidentally deleted an intentional
change that got borked by a merge conflict or something. I don't think I
did, tho, based on the age of the git blame on the files deleted here.

# Testing

None
@bfops bfops mentioned this pull request Dec 15, 2025
3 tasks
github-merge-queue bot pushed a commit that referenced this pull request Dec 16, 2025
# Description of Changes

Add back the instructions for regenerating CLI docs, which were removed
in #3343. I also made a
script for it.

This also fixes the CI checking this file, which was silently broken in
the same PR.

I have **not** verified that this works in Git Bash in Windows.

# API and ABI breaking changes

None

# Expected complexity level and risk

1

# Testing
- [x] CI passes
- [x] CI fails if I change the CLI reference
- [x] CLI reference looks visually reasonable on a local `pnpm dev`

---------

Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no runtime change This change does not affect the final binaries release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants