Conversation
fbd26f2 to
aa7cca6
Compare
ae90c28 to
2a7bf53
Compare
46c21ab to
f590ae0
Compare
jdetter
left a comment
There was a problem hiding this comment.
One question on this one so far, otherwise the rest of the edits look good to me
jdetter
left a comment
There was a problem hiding this comment.
Reminder that I still needed to run this command in order to get the docs rendering:
pnpm add @docusaurus/theme-common
jdetter
left a comment
There was a problem hiding this comment.
I've reviewed a majority of the documentation and I think it looks good. There are just 2 issues to fix here I think:
- Fix the issue with having to manually install @docusaurus/theme-common
- Fix the code formatting issues in the Unity tutorial
besides that I think this is ready to go. Let me know when you want me to take another look 👍
0892495 to
9f04566
Compare
|
baf85ff to
b4d4691
Compare
Looks great! All the Unreal stuff is complete. |
jdetter
left a comment
There was a problem hiding this comment.
Few more formatting issues here
42faabf to
8050d6b
Compare
Signed-off-by: Julien Lavocat <JulienLavocat@users.noreply.github.com>
Signed-off-by: Julien Lavocat <JulienLavocat@users.noreply.github.com>
Removed the S3 upload step from the docs workflow. Signed-off-by: Julien Lavocat <JulienLavocat@users.noreply.github.com>
b4da137 to
b75b278
Compare
JasonAtClockwork
left a comment
There was a problem hiding this comment.
The Unreal work looks great!
Somehow (apparently after #3494) we wound up with a bunch of duplicate folders in our repo, both the old title-case names and the new lower-case names. All of the remaining files in the title-case directories have their last change in #3343, well before #3494, so I don't believe we're losing any intermediate changes by deleting them. I'm not sure how this happened, but it seems to be an easy fix.
# Description of Changes Somehow (apparently after #3494) we wound up with a bunch of duplicate folders in our repo, both the old title-case names and the new lower-case names. All of the remaining files in the title-case directories have their last change in #3343, well before #3494, so I don't believe we're losing any intermediate changes by deleting them. I'm not sure how this happened, but it seems to be an easy fix. # API and ABI breaking changes N/a # Expected complexity level and risk 2 - some small possibility that I accidentally deleted an intentional change that got borked by a merge conflict or something. I don't think I did, tho, based on the age of the git blame on the files deleted here. # Testing None
# Description of Changes Add back the instructions for regenerating CLI docs, which were removed in #3343. I also made a script for it. This also fixes the CI checking this file, which was silently broken in the same PR. I have **not** verified that this works in Git Bash in Windows. # API and ABI breaking changes None # Expected complexity level and risk 1 # Testing - [x] CI passes - [x] CI fails if I change the CLI reference - [x] CLI reference looks visually reasonable on a local `pnpm dev` --------- Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com> Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>


Description of Changes
pnpm buildon pull requests targetingmaster.This command checks for broken links and images and ensures the site builds correctly.
docs/releasebranch.Important: The workflows haven't been tested yet due to the fact that they need to be merged first before being able to run. It's a fairly basic workflow I don't expect this to block anyone but anyways I will make another PR with the complete changes when I can actually run it.
API and ABI Breaking Changes
No breaking changes for SpacetimeDB users.
Documentation contributors should experience minimal disruption — content is still written in Markdown.
Expected Complexity Level and Risk
Complexity: 3/5
Reasons:
Several adjustments were made to fit Docusaurus conventions:
:::server-rustblocks with Docusaurus<Tabs/>components.docs/static/images.Customized Docusaurus CSS and one component to apply our theme and color palette.
Testing
Tested locally.
Review Notes
This PR involves many file changes — a full code review is likely not productive.
Instead, please focus on verifying that the documentation content was migrated correctly:
You can follow the updated README for instructions on running Docusaurus locally.