Merged
Conversation
Allows the SpacetimeDBClient to be configured with or without confirmed reads. Like for [TypeScript], the parameter is optional -- the server chooses the default if not set explicitly. [TypeScript]: #3247
JasonAtClockwork
previously requested changes
Nov 17, 2025
Contributor
JasonAtClockwork
left a comment
JasonAtClockwork
left a comment
There was a problem hiding this comment.
LGTM - when we improve testing in the future we may want to include confirmation of this flag being set and read.
JasonAtClockwork
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the SpacetimeDBClient to be configured with or without confirmed reads. Like for TypeScript, the parameter is optional -- the server chooses the default if not set explicitly.
Expected complexity level and risk
1
Testing
I don't actually know what I'm doing 😅