fix(astro): Remove duplicate auth headers values#3948
Merged
wobsoriano merged 2 commits intomainfrom Aug 13, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 30b7506 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wobsoriano
commented
Aug 13, 2024
| } | ||
|
|
||
| const response = await decorateRequest(context.locals, handlerResult!, requestState); | ||
| const response = decorateRequest(context.locals, handlerResult); |
Member
Author
There was a problem hiding this comment.
The x-clerk-auth-* headers are already set here
javascript/packages/astro/src/server/clerk-middleware.ts
Lines 113 to 115 in c443544
wobsoriano
changed the title
octoper
approved these changes
Aug 13, 2024
Contributor
|
@wobsoriano Thanks for fixing this so fast after I reported it on Discord! |
Member
Author
|
@mlafeldt You're welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the redundant part where we set the
x-clerk-auth-*headers twice, ensuring each header appears only once in the response. This also cleans up some types and unused non-null assertions.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change