Skip to content

feat(elements): Add SAML support#3842

Merged
tmilewski merged 1 commit intomainfrom
tm.feat/elements-saml
Jul 31, 2024
Merged

feat(elements): Add SAML support#3842
tmilewski merged 1 commit intomainfrom
tm.feat/elements-saml

Conversation

@tmilewski
Copy link
Member

@tmilewski tmilewski commented Jul 30, 2024

Description

<Clerk.Connection name="saml">Continue with SAML</Clerk.Connection>

Requires the following inputs:

  • Sign In: identifier
  • Sign Up: emailAddress

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@tmilewski tmilewski requested a review from alexcarpenter July 30, 2024 19:18
@tmilewski tmilewski self-assigned this Jul 30, 2024
@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2024

🦋 Changeset detected

Latest commit: a490f29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/elements Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@alexcarpenter alexcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, do we need any docs updated to accompany this change?

@tmilewski
Copy link
Member Author

Looks good to me, do we need any docs updated to accompany this change?

We will, yeah, I just didn't want to do it until we all agreed on this.

@alexcarpenter alexcarpenter requested a review from dstaley July 30, 2024 23:26
@tmilewski tmilewski merged commit 51f9838 into main Jul 31, 2024
@tmilewski tmilewski deleted the tm.feat/elements-saml branch July 31, 2024 14:12
brkalow pushed a commit that referenced this pull request Aug 1, 2024
wobsoriano pushed a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants