Skip to content

fix(elements): Update isLoggedInAndSingleSession guard with navigation#3841

Merged
alexcarpenter merged 5 commits intomainfrom
alexcarpenter/elements-signin-already-logged-in
Jul 30, 2024
Merged

fix(elements): Update isLoggedInAndSingleSession guard with navigation#3841
alexcarpenter merged 5 commits intomainfrom
alexcarpenter/elements-signin-already-logged-in

Conversation

@alexcarpenter
Copy link
Member

Description

When isLoggedInAndSingleSession during sign in flow, redirect with buildAfterSignInUrl

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2024

🦋 Changeset detected

Latest commit: a34ad0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/elements Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexcarpenter alexcarpenter requested a review from tmilewski July 30, 2024 15:10
Copy link
Member

@tmilewski tmilewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Let's make this a minor release though. It technically changes the current expected functionality.

@tmilewski tmilewski self-requested a review July 30, 2024 15:13
@alexcarpenter alexcarpenter requested a review from tmilewski July 30, 2024 15:50
@alexcarpenter alexcarpenter merged commit 36c6921 into main Jul 30, 2024
@alexcarpenter alexcarpenter deleted the alexcarpenter/elements-signin-already-logged-in branch July 30, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants