Conversation
|
Thank you for working on this! There's a few things that I think should be changed, let me know what you think: First, I feel like loading from just one folder with fixed names is less than clear. The CLIP/mT5 model being separately selectable would make more sense, then we can split it up like this:
(the user would have to rename the files from just "pytorch_model.bin") Second, there's a lot of small changes that need to be made, and some code redundancy that needs removed. For example, the MT5/CLIP are currently non-standard, and don't work with the regular text encode node, though this might be hard to implement. I can't really merge this as-is, but I can adapt/fix parts of it and add it to the main repo if that works for you. I'll add your name to the readme for credit. Oh, and I noticed you're saving the embeddings for testing. Could you send me those for easy debugging? |
|
I agree with what you said. I have added support for custom resolution, batch image generation, and img2img generation. If there is anything worth referring to, you can go directly https://github.com/chaojie/ComfyUI_ExtraModels |

The functionality has been implemented first, but further optimization is needed. If it is possible to merge, need to modify the README first