Skip to content

Fix for persistent callbacks#476

Closed
MarshallVielmetti-jhuapl wants to merge 3 commits intochromiumembedded:masterfrom
MarshallVielmetti-jhuapl:merge-branch
Closed

Fix for persistent callbacks#476
MarshallVielmetti-jhuapl wants to merge 3 commits intochromiumembedded:masterfrom
MarshallVielmetti-jhuapl:merge-branch

Conversation

@MarshallVielmetti-jhuapl
Copy link
Copy Markdown

My fix for #398

  1. Add two private methods to CefQueryCallback_N.java, makePersistent and getIsPersistent, and a private boolean variable persistent_
  2. In MessageRouterHandler::OnQuery (message_router_handler.cpp:28), check the value of persistent, if true use JNI_CALL_VOID_METHOD to call makePersistent. This will set a boolean value to true in CefQueryCallback_N
  3. In CefQueryCallback_N.cpp::Success, use JNI_CALL_BOOLEAN_METHOD to call getIsPersistent, check the boolean value, and if its true then do not call ClearSelf

I am totally open to fixing anything here, this is my first attempt at open source contribution so please let me know if I'm forgetting something!

@magreenblatt
Copy link
Copy Markdown
Collaborator

Looks like you submitted a PR at https://bitbucket.org/chromiumembedded/java-cef/pull-requests/120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants