Conversation
|
@mpena2099 thanks for the PR. Please see commit 8dac0f7. You need to add the same version handling. Also can you add a new test which demonstrates the bug & verifies the fix? Thanks! |
|
OK @atodorov, I'll try again soon. Thanks, |
|
@atodorov, still some check errors... |
|
@mpena2099 sorry to bitch about it but you will have to add a few more bits to this PR before I can merge it:
Please see commit 8dac0f7 for reference. There you will also find some unicode data, which is used during testing. Feel free to add more data if the existing one doesn't fit the charts you want to create. EDIT: don't worry about the failing TravisCI jobs, there are lots of pylint errors currently but please make sure code you touch doesn't introduce more pylint errors. |
Same kind of error as grantmcconnaughey#3