Closed
Conversation
cbb330
added a commit
that referenced
this pull request
Feb 20, 2026
cbb330
added a commit
that referenced
this pull request
Feb 20, 2026
Implemented comprehensive test for ORC count optimization with predicate pushdown. Tests verify that CountRows can use stripe statistics to count rows without reading data when predicates can be fully evaluated from min/max statistics. Test cases cover: - No filter (literal true) - counts all rows using metadata - Filters matching entire stripes - can use statistics - Filters matching no stripes - returns 0 using statistics - Filters matching partial stripe content - returns nullopt (requires scan) - Equality predicates - cannot determine from min/max, returns nullopt - Null stripe handling - verifies all-null stripes are correctly handled The test validates the optimization logic in TryCountRows that decides whether to use fast statistics-based counting or fall back to full scan. Verified: Count optimization works correctly for stripe-aligned filters and properly falls back for partial matches. Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
cbb330
added a commit
that referenced
this pull request
Feb 20, 2026
cbb330
force-pushed
the
mark-task-9-complete
branch
from
a07e2b9 to
959b454
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task #9 (ResolvePredicateFields) is complete.