Improve docstring for approximation_grain in ParallelogramOLF#687
Open
kennethshsu wants to merge 1 commit intomainfrom
Open
Improve docstring for approximation_grain in ParallelogramOLF#687kennethshsu wants to merge 1 commit intomainfrom
kennethshsu wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
=======================================
Coverage 85.08% 85.08%
=======================================
Files 85 85
Lines 4896 4896
Branches 629 629
=======================================
Hits 4166 4166
Misses 521 521
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Docstring-only change; no functional or behavioral impact.
Overview
Improves the
ParallelogramOLFdocstring by documenting theapproximation_grainparameter, including supported values ('M'monthly,'D'daily) and the effect of daily granularity (leap-year handling when assigning factors to origin periods).Written by Cursor Bugbot for commit b984f80. This will update automatically on new commits. Configure here.