Skip to content

Fix broken thread safety by widening critical section on ConnectionPool #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leehambley merged 2 commits into from
Jan 19, 2019
Merged

Fix broken thread safety by widening critical section on ConnectionPool #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
291ad54
Fix broken thread safety by widening critical section
aeroastro Nov 2, 2018
918cfd8
Update README.md for #447
aeroastro Jan 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ appear at the top.
## [Unreleased][]

* Your contribution here!
* [#447](https://github.com/capistrano/sshkit/pull/447): Fix broken thread safety by widening critical section - [Takumasa Ochi](https://github.com/aeroastro)

## [1.18.0][] (2018-10-21)

Expand Down
2 changes: 1 addition & 1 deletion lib/sshkit/backends/connection_pool.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,9 @@ def thread_safe_find_or_create_cache(key)
# Update cache key with changed args to prevent cache miss
def update_key_if_args_changed(cache, args)
new_key = cache_key_for_connection_args(args)
return if cache.same_key?(new_key)

caches.synchronize do
return if cache.same_key?(new_key)
caches[new_key] = caches.delete(cache.key)
cache.key = new_key
end
Expand Down