This repository was archived by the owner on Sep 26, 2022. It is now read-only.
Fix various cookies issues#171
Merged
thomasvidas merged 6 commits intocapacitor-community:masterfrom Nov 10, 2021
Merged
Conversation
…o use the format of the Set-Cookie HTTP response header
…method to clearAllCookies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following cookies issues:
setCookie()on android. Currently, it is not possible to set a Set-Cookie HTTP response header as part of the cookie value due to the encoding step. For instance, setting a cookie with the valueen; Max-Age=5will be replaced toen%3B+Max-Age%3D5and hence Max-Age will not be taken into account. Thus, this PR removes the encoding/decoding steps on android.clearCookies()on android is implemented differently than on ios. On android all cookies are removed, on ios only those from the passed URL. This PR fixes this issue by introducing a new methodclearAllCookies()and adjusting the respective methods on android/ios.getCookiesMap()on ios.