This repository was archived by the owner on Sep 26, 2022. It is now read-only.
Fix "getCookie" on ios#156
Merged
thomasvidas merged 1 commit intocapacitor-community:masterfrom Aug 11, 2021
Merged
Conversation
1 task
shanselm-ergon
pushed a commit
to ergon/http
that referenced
this pull request
Sep 24, 2021
thomasvidas
added a commit
that referenced
this pull request
Nov 9, 2021
* Add data to the request if they are present. Don't fail based on the HTTP method (each HTTP method may have a body or not). * Update README Add note that we use ergon-master branch * Update HttpRequestHandler.swift Adjust data handling in the ios HttpRequestHandler to check the data, if available, for correctness and fail otherwise. * Update HttpRequestHandler.swift Remove duplicat code, sorry for that. * Replace throw with reject for safety reasons * Add data to the request if they are present. Don't fail based on the HTTP method (each HTTP method may have a body or not). * Update HttpRequestHandler.swift Adjust data handling in the ios HttpRequestHandler to check the data, if available, for correctness and fail otherwise. * Update HttpRequestHandler.swift Remove duplicat code, sorry for that. * fix(iOS): pass http method to request functions on ios (#152) * chore: release 1.1.1 * release: 1.1.2 * chore(iOS): remove local pods from project * refactor: add postbuild script to install up to date pods * refactor: change postbuild to prepublishOnly * release: release 1.1.2 * refactor(android): JavaDoc and code cleanup * fix(iOS): Add "getCookie" as plugin method for ios (#156) * feat: Add support for disabling automatic HTTP redirects on android/ios (#157) * Update HttpOptions * Add support for disabling automatic HTTP redirects on android * Add support for disabling automatic HTTP redirects on ios * fix: default content-type consistent with native impl (#158) * release: 1.2.0 * Replace throw with reject for safety reasons * Revert "Update README" This reverts commit aa6d19e. * feat(web): pass-through string-type requests * fix(ios): fix crash on json serialization failure * feat(ios): write string body as-is Co-authored-by: Stefan Hanselmann <stefan.hanselmann@ergon.ch> Co-authored-by: graefenhain <88032701+graefenhain@users.noreply.github.com> Co-authored-by: Stefan Hanselmann <69970522+shanselm-ergon@users.noreply.github.com> Co-authored-by: Joe Flateau <joe@joeflateau.net> Co-authored-by: Thomas Vidas <hello@thomasvidas.com> Co-authored-by: Thomas Vidas <thomasvidas@users.noreply.github.com> Co-authored-by: Felix Schwarzmeier <felixsla21@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, executing "getCookie()" on ios throws the followeing error: "getCookie() is not implemented on ios".
This PR fixes this issue.