This repository was archived by the owner on Sep 26, 2022. It is now read-only.
Use the default response type if the response is not ok#117
Merged
thomasvidas merged 1 commit intocapacitor-community:capacitor-v3from Apr 9, 2021
herecoulbeyourname:feature/responseType-errorResponse
Merged
Use the default response type if the response is not ok#117thomasvidas merged 1 commit intocapacitor-community:capacitor-v3from herecoulbeyourname:feature/responseType-errorResponse
thomasvidas merged 1 commit intocapacitor-community:capacitor-v3from
herecoulbeyourname:feature/responseType-errorResponse
Conversation
-Since the response type was meant for the ok response, use either 'text' or 'json' (if the 'content-type' header matches) to avoid parsing errors of an error response that might not conform to the specified response type in the HttpOptions. -This behavior is consistent with the Android implementation of the plugin
thomasvidas
approved these changes
Apr 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Since the response type was meant for the ok response, use either 'text' or 'json' (if the 'content-type' header matches) to avoid parsing errors of an error response that might not conform to the specified response type in the HttpOptions.
-This behavior is consistent with the Android implementation of the plugin