fix: use React.forwardRef and improve memoization#41
Merged
souhe merged 1 commit intocallstack:masterfrom Mar 29, 2019
satya164:@satya164/forward-ref
Merged
fix: use React.forwardRef and improve memoization#41souhe merged 1 commit intocallstack:masterfrom satya164:@satya164/forward-ref
souhe merged 1 commit intocallstack:masterfrom
satya164:@satya164/forward-ref
Conversation
hawkrives
approved these changes
Mar 15, 2019
Contributor
|
(Apologies! I hit the wrong button while on mobile.) |
souhe
approved these changes
Mar 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
React.forwardRefis also available in the same version asReact.createContext, we can also drop extra handling for refs.