feat: add props to FAB, Button and Chip to support prefetching#4217
Open
robinlindhout wants to merge 2 commits intocallstack:mainfrom
Open
feat: add props to FAB, Button and Chip to support prefetching#4217robinlindhout wants to merge 2 commits intocallstack:mainfrom
robinlindhout wants to merge 2 commits intocallstack:mainfrom
Conversation
|
Hey @robinlindhout, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
Contributor
|
@lukewalczak any chance this could get merged in. This is more and more important as expo-router will enable pre-fetching too in newer versions. It's the last reason why I have a fork of react-native-paper :-) |
Member
|
It will be released in |
Member
|
@robinlindhout , please check the CI issue |
1062366 to
1da5d15
Compare
Author
|
@lukewalczak LGTM 👍🏻 |
Contributor
|
@lukewalczak Can we get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The other components like IconButton and ListItem already supports these props as they use Pressable props and spread them.
Fixes: #3748
Continuation of #3750