Conversation
thekaveman
approved these changes
Apr 8, 2025
Member
There was a problem hiding this comment.
👍 nice
Can you also take a follow-up to update the littlepay version please
- https://github.com/cal-itp/littlepay/blob/main/.devcontainer/Dockerfile#L1
- https://github.com/cal-itp/littlepay/blob/main/.github/workflows/release.yml#L34
And eligibility-api:
- https://github.com/cal-itp/eligibility-api/blob/main/.devcontainer/Dockerfile#L1
- https://github.com/cal-itp/eligibility-api/blob/main/.github/workflows/.python-version
These aren't directly related, but libraries used by benefits and we should just make sure everything is on the same version.
This was referenced Apr 8, 2025
This was referenced Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51
Tested Benefits locally by:
docker-python-webimage locally using this brancheligibility-serverimage locally using the localdocker-python-webimage built from this branchclientservice and the dev container) from the localdocker-python-webimageFollow-up
Update
.github/workflows/.python-versionandtool.black.target-versioninpyproject.tomlto 3.12 in