Fix Decimal Column Definition Issue When Scale is 0#2377
Merged
dereuromark merged 1 commit intocakephp:0.xfrom Oct 22, 2025
Merged
Fix Decimal Column Definition Issue When Scale is 0#2377dereuromark merged 1 commit intocakephp:0.xfrom
dereuromark merged 1 commit intocakephp:0.xfrom
Conversation
In CakePHP's MySQL adapter, when defining a Decimal column with scale set to 0 (e.g. DECIMAL(65,0) or DECIMAL(10,0)), the generated SQL definition was missing precision information. Specifically, when users need to create a DECIMAL(65) column (precision=65, scale=0), due to the condition check $column->getScale() returning 0, which is treated as false in boolean context, the entire condition $column->getPrecision() && $column->getScale() evaluates to false, causing the precision and scale definition to be skipped.
This was referenced Oct 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CakePHP's MySQL adapter, when defining a Decimal column with scale set to 0 (e.g.
DECIMAL(65,0)orDECIMAL(10,0)), the generated SQL definition was missing precision information.Specifically, when users need to create a
DECIMAL(65)column (precision=65, scale=0), due to the condition check$column->getScale()returning 0, which is treated as false in boolean context, the entire condition$column->getPrecision()&&$column->getScale()evaluates to false, causing the precision and scale definition to be skipped.