Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves cakephp/phinx#1891
When setting
'CURRENT_TIMESTAMP'as a default value on non-datetime columns (like VARCHAR/TEXT), it was not being quoted properly, causing SQL errors.The logic was inverted - it would only quote strings that DON'T start with
CURRENT_TIMESTAMP, when it should only skip quoting for datetime-related columns.with the buggy code, these scenarios would FAIL:
The Fix:
Only skip quoting CURRENT_TIMESTAMP for datetime-related column types.
For other types (like string), it should be quoted as a literal string value.