Skip to content

Conversation

@ADmad
Copy link
Member

@ADmad ADmad commented Apr 9, 2023

No description provided.

@ADmad ADmad added this to the 5.x milestone Apr 9, 2023
@ADmad ADmad force-pushed the 5.x-ci-workflow branch 3 times, most recently from c9e145a to e76a2ab Compare April 9, 2023 09:16
@ADmad ADmad force-pushed the 5.x-ci-workflow branch from e76a2ab to bdb3328 Compare April 9, 2023 09:24
@ADmad ADmad marked this pull request as ready for review April 9, 2023 09:33
@ADmad
Copy link
Member Author

ADmad commented Apr 9, 2023

Looking through squizlabs/PHP_CodeSniffer's testsuite GA workflow I figured out how to run our test suite on PHP 8.1+ without updating phpunit.

@dereuromark dereuromark merged commit 3897d72 into 5.x Apr 9, 2023
@dereuromark dereuromark deleted the 5.x-ci-workflow branch April 9, 2023 10:11
@ADmad
Copy link
Member Author

ADmad commented Apr 9, 2023

@dereuromark Can you please add the phpstan checks you added in #369 on top of this please? Then that PR can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants