-
-
Notifications
You must be signed in to change notification settings - Fork 357
feat: Add option to hide clinical data tab in study view #5273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
src/config/IAppConfig.ts
Outdated
| clickhouse_mode: boolean; | ||
| download_custom_buttons_json: string; | ||
| feature_study_export: boolean; | ||
| skin?: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have a convention above that dot notation gets converted to _. lets keep that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you test it this, the backend should automatically convert the dot notation. so i would think this wouldn't work. let me know if you need hlep testing this
my-index.ejs
Outdated
| <script> | ||
| window.devContext = true; | ||
| window.portalProperties = { skin: { hide_clinical_data_tab_study_view: false } }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this for testing purposes?
src/config/config.ts
Outdated
| } | ||
| } | ||
|
|
||
| let portalProperties: any = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this for?
alisman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
f30873b to
20d89b2
Compare
aabd624 to
b647ffa
Compare
|
Thanks for the review @alisman , Sorry for the late reply since I was busy with my semester exams and when I came back to my hometown I had frequent power cuts due to cyclone. I'll be active here forward to this
Kindly let me know if there are any more problems with this commit. Thanks ! |

This adds a portal property skin.hide_clinical_data_tab_study_view, which can hide the Clinical Data tab in the Study View page
Fixes cBioPortal/cbioportal#11653
Describe changes proposed in this pull request:
Checks
This is a minor visual change controlled by a configuration flag and does not require a dedicated test.
Any screenshots or GIFs?
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>to determine thatand notify them either through slack or by assigning them as a reviewer on the PR