Omit structs and unions that would be empty.#613
Closed
sunfishcode wants to merge 3 commits intobytecodealliance:mainfrom
Closed
Omit structs and unions that would be empty.#613sunfishcode wants to merge 3 commits intobytecodealliance:mainfrom
sunfishcode wants to merge 3 commits intobytecodealliance:mainfrom
Conversation
Empty structs and unions are a non-standard extension in C, and have a different layout between C and C++, so avoid emitting them. If a generated struct or union would have zero members, avoid emitting it.
sunfishcode
force-pushed
the
sunfishcode/no-empties-in-c
branch
from
63fd0e5 to
f56840f
Compare
sunfishcode
force-pushed
the
sunfishcode/no-empties-in-c
branch
from
f56840f to
865e1ab
Compare
Member
|
I believe this is resolved by WebAssembly/component-model#218, so closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty structs and unions are a non-standard extension in C, and have a different layout between C and C++, so avoid emitting them. If a generated struct or union would have zero members, avoid emitting it.