Update wasm-tools and wit-bindgen crates#8965
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Jul 16, 2024
Merged
Update wasm-tools and wit-bindgen crates#8965alexcrichton merged 2 commits intobytecodealliance:mainfrom
alexcrichton merged 2 commits intobytecodealliance:mainfrom
Conversation
This keeps things updated and pulls in some new features from wasm-tools: * Multiple returns in the component model are now gated by default. This is reflected in a new `Config` option and CLI flag. The hope is to remove this feature is no one ends up needing it. * Support for more `shared` things were added but the feature is always disabled so internal handlers just panic. Tests were updated to not use multiple returns where appropriate, except for one test which is specifically testing for multiple returns and how it's reflected into the Rust type system.
pchickey
approved these changes
Jul 16, 2024
fitzgen
approved these changes
Jul 16, 2024
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jul 24, 2024
This commit fixes an issue from the last upgrade of wasm-tools where multiple returns on component model functions are now gated by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps things updated and pulls in some new features from wasm-tools:
Multiple returns in the component model are now gated by default. This is reflected in a new
Configoption and CLI flag. The hope is to remove this feature is no one ends up needing it.Support for more
sharedthings were added but the feature is always disabled so internal handlers just panic.Tests were updated to not use multiple returns where appropriate, except for one test which is specifically testing for multiple returns and how it's reflected into the Rust type system.