Link with -pthread on Unix
#95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to fix some unresolved symbols in the `rand` crate on some Unix platforms.
jeremywiebe
added a commit
to Khan/fastlike
that referenced
this pull request
Aug 4, 2021
## Summary: A[ linker issue](bytecodealliance/wasmtime-go#94) in wasmtime-go caused build failures in Linux environments. This was [fixed](bytecodealliance/wasmtime-go#95) and shipped in [v0.29](https://github.com/bytecodealliance/wasmtime-go/releases/tag/v0.29.0) and so we need to upgrade. This upgrade includes a wasmtime-go fix for a linker bug on Linux where the pthread library wasn't linked and caused builds to fail on Linux. The upgrade to wasmtime-go v0.29 also includes a migration to wasmtime's new C api (bytecodealliance/rfcs#11) The changes were largely guided by the RFC and the [example code](https://github.com/bytecodealliance/wasmtime-go/blob/main/doc_test.go). Issue: LP-10085 ## Test plan: `make test` Author: jeremywiebe Reviewers: jaredly Required Reviewers: Approved by: jaredly Checks: ✅ Run tests, ✅ Build wasm files for tests Pull request URL: #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix some unresolved symbols in the
randcrate on some Unixplatforms.
Closes #94