Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

improved login and config subcommands#288

Merged
calvinrp merged 1 commit intobytecodealliance:mainfrom
calvinrp:fix-config
May 15, 2024
Merged

improved login and config subcommands#288
calvinrp merged 1 commit intobytecodealliance:mainfrom
calvinrp:fix-config

Conversation

@calvinrp
Copy link
Collaborator

@calvinrp calvinrp commented May 15, 2024

  • warg config now lets you modify your current settings instead of forcing an overwrite
  • warg login --registry asks you if you want to set that registry as your home / default registry
  • Clearer messaging on the CLI on what registry is being used

@calvinrp calvinrp requested review from lann and macovedj May 15, 2024 17:37
@calvinrp calvinrp changed the title improved login and config` subcommands improved login and config subcommands May 15, 2024
.map(|u| u.to_string());
let mut changing_home_registry = false;

let config = if self.overwrite {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is --overwrite even needed after this change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not sure. But keep for now

@calvinrp calvinrp merged commit a87e0e4 into bytecodealliance:main May 15, 2024
@calvinrp calvinrp deleted the fix-config branch May 15, 2024 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants