chore(ci): add clippy#248
Merged
vados-cosmonic merged 2 commits intobytecodealliance:mainfrom Jul 14, 2025
Merged
Conversation
vados-cosmonic
force-pushed
the
chore(ci)=add-clippy
branch
from
f2250bb to
1eba5fe
Compare
Member
|
I'm in favor of adding a Clippy check, but let's make sure that we're judicious in which lints we enable, instead of manually overriding those we don't like in the code. We could copy the configuration from Wasmtime, for example? |
Contributor
Author
|
Sure, those seem like reasonable defaults |
Contributor
Author
|
Wait, actually @tschneidereit thinking about it some more -- I'm not sure we should allow then re-add. How about we allow [EDIT] Change is done -- the Cargo.toml changes are in |
vados-cosmonic
force-pushed
the
chore(ci)=add-clippy
branch
from
bf6c5b3 to
94f02f7
Compare
vados-cosmonic
force-pushed
the
chore(ci)=add-clippy
branch
from
94f02f7 to
b697755
Compare
tschneidereit
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appeasing clippy is clearly not a goal, but it may be nice to have the code be a bit more consistent and enforcably so.