Skip to content

"egg-commit-log-edit: Wrong type argument: stringp, nil" when user.name not set #57

@LuisFors

Description

@LuisFors

Attempting to commit when git is not yet configured results in the above error, inside of egg-text.

egg-text has a null check, but since it is a macro, it checks if the function passed to it, (plist-get state :name), is null, when in fact the value it returns is null.

Does egg-text have to be a macro?
Can we set a default? (like OS username)

New users are more likely to not have git configured, and are more likely to be stumped by the error message, so I think this is worth fixing.

Same problem occurs when user.email is not set.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions