Closed
Conversation
Contributor
gitlost
commented
Oct 9, 2024
- code128: Avoid extraneous CodeC switch Avoid extraneous CodeC switch (with immediate switch back to CodeA/B) by re-checking digit runlength >= 4 after enca/encb push
- maxicode: Zero-pad US postcodes that lack "+4" (Annex B.1.4a) Adapted from OkapiBarcode, with stricter interpretation (only pad if "+4" totally absent), props Daniel Gredler
Avoid extraneous CodeC switch (with immediate switch back to CodeA/B) by re-checking digit runlength >= 4 after enca/encb push Also simplify `numsscr` to return only `nums` as `nchars` unused (cf codablockf and code16k which similarly could be simplified)
Adapted from OkapiBarcode, with stricter interpretation (only pad if "+4" totally absent), props Daniel Gredler
Member
|
@gitlost Was this closed in error, or are you reworking it? |
Contributor
Author
|
My local master was out of sync so just fixed it up (I think) and pushed
again!
…On Wed, Oct 9, 2024 at 5:53 PM Terry Burton ***@***.***> wrote:
@gitlost <https://github.com/gitlost> Was this closed in error, or are
you reworking it?
—
Reply to this email directly, view it on GitHub
<#273 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADVVPTS7DKTBFAR5LIDXUTZ2VNO5AVCNFSM6AAAAABPU6AGNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBSHAZTGMRVGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
Thanks! I'm not sure whether you spotted the opportunities for further optimisation of Code 128 in #272 If you start to look then just let me know. Otherwise I'll poke it next week when I'm at the WG1 meeting in London. |
Contributor
Author
|
I hadn't no, just checked them out now. Good cases, zint fails on the 1st one (FNC4), same as bwipp, as both use 5 chars as the non-terminal cut-off. A simple fix for that could be lower the cut-off to 4 - will check it out. zint passes the 2 middle cases which bwipp fails, and both pass the last one. Will have a look and let you know if I make headway (hopefully avoiding the usual whack-a-mole issues). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.