Skip to content

Pr144 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wessmith merged 2 commits into from
May 31, 2019
Merged

Pr144 #153

wessmith merged 2 commits into from
May 31, 2019

Conversation

@wessmith
Copy link
Member

@wessmith wessmith commented May 31, 2019

Updates PR #144

徐强 and others added 2 commits May 31, 2019 19:17
@wessmith
BUGFIX fix when route like “/say/:a/:b”, the route would not
1d95ecb 
    /say/:a/:b, because DPLNamedGroupComponentPattern ask for at least two
    character
@wessmith
Add test for single character named group
94874fe
@wessmith wessmith requested a review from chrismaddern as a code owner May 31, 2019 23:24
@wessmith wessmith removed the request for review from chrismaddern May 31, 2019 23:25
@wessmith
Copy link
Member Author

wessmith commented May 31, 2019

Resolves #144

@wessmith wessmith merged commit c5e737b into master May 31, 2019
@wessmith wessmith deleted the pr144 branch May 31, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wessmith