Open
Conversation
Member
|
Hi, there are a couple things bothering me here:
Also, you changed the package name in composer.json in your PR! |
58a6b1f to
62cb8bb
Compare
22500f6 to
f6404c8
Compare
Author
|
Sorry of the last commit with package rename. It was accidentally pushed, after I rebase my fork. As I mention, in my case I use this library in combination with another one, wich give me response (originaly in JSON) but automatically transformed to StdClass (no simple option how to change this behaviour]. Without making mapToObject public, there will be need to encode it back to JSON and then call map -> back to StdClass and then map it. In question of changin name of the method, will be OK mapToObject -> mapStdClassToObject ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is sometimes useful to have option map StdClass object directly, because it is very often returned from other API clients implementations. It make no sense to encode response from other libraries to json to be decoded in next step in map function to StdClass object back.