Resolve incorrect order of lambda layers with context flag @aws-cdk/aws-lambda:recognizeLayerVersion#6
Merged
mnapoli merged 1 commit intobrefphp:mainfrom Jun 29, 2023
fbuchlak:main
Merged
Resolve incorrect order of lambda layers with context flag @aws-cdk/aws-lambda:recognizeLayerVersion#6mnapoli merged 1 commit intobrefphp:mainfrom fbuchlak:main
mnapoli merged 1 commit intobrefphp:mainfrom
fbuchlak:main
Conversation
Member
|
Woww this is crazy 🤯 I don't understand why they did that, but thank you for figuring this out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on discussions 1560, 1580 and pull request #4
New cdk projects created with
cdk initprovides set of feature flags. Specifically @aws-cdk/aws-lambda:recognizeVersionProps which changes order of lambda layers (see Function.renderLayers).This pull request changes
ids of created layers (based on their priorities described in corresponding constructs) and allows to create test templates withAppProps.There might be a problem if you want to add additional layers to bref construct along with mentioned flag.
To resolve such problems, you may need to "name" additional layers correctly (so they are sorted as you wish in previously mentioned
renderLayersmethod).