Handle stale connections in fetch_base_experiment() #1178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Long eval jobs (500+ docs) on Azure VMs freeze for ~15 minutes after reaching 100% completion. The failure occurs when
summarize()callsfetch_base_experiment(), which usesapp_conn()(Vercel IP) that sits idle during the eval run.Azure NAT gateways have a 4-minute idle timeout that silently closes stale connections. When
fetch_base_experiment()tries to use the stale connection, it fails withConnectionError.Solution
Added retry logic with connection reset to
fetch_base_experiment():conn._reset()) on retry to create fresh HTTP sessionNoneafter max retries instead of raisingChanges
logger.py: Added retry logic tofetch_base_experiment()test_stale_connection.py: Integration test using real HTTP server to simulate NAT timeoutTesting
cd sdk/py PYTHONPATH=src python3 -m unittest braintrust.test_stale_connection -vTest uses a real HTTP server that simulates NAT gateway timeout behavior (0.5s timeout simulates 4-minute Azure NAT timeout).