Fixed miscalculation of position on Safari#70
Closed
blipntime wants to merge 1 commit intobootstarted:masterfrom
Closed
Fixed miscalculation of position on Safari#70blipntime wants to merge 1 commit intobootstarted:masterfrom
blipntime wants to merge 1 commit intobootstarted:masterfrom
Conversation
tchon
approved these changes
Aug 7, 2018
Contributor
|
Thanks for the PR. Taking a look to see if this is the correct fix. |
Drabin
approved these changes
Aug 7, 2018
Contributor
|
While this is a subtle problem at play here, that seems at least initially triggered by setting I'll try and investigate this further in #71, but simply turning off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Safari, the flowtip appears far from the intended position (usually way to the top):
One way to fix this is to remove an extra condition. After the fix:
Please advise if this is the best way to fix the issue or if there is a better solution.