Bugfix duplicate symbol error in time_measure.hpp#63
Bugfix duplicate symbol error in time_measure.hpp#63spreadsort merged 3 commits intoboostorg:developfrom
Conversation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Free functions that are defined in header files must be qualified inline in order to avoid duplicate symbol errors at link time. Bugfix two cases: - boost::sort::common::now() - boost::sort::common::subtract_time()
|
I see a test failure: ...failed clang-linux.compile.c++ bin.v2/libs/sort/test/test_parallel_stable_sort.test/clang-linux-3.8/debug/cxxstd-14-iso/optimization-speed/threading-multi/visibility-hidden/test_parallel_stable_sort.o... "clang++" -c -x c++ -std=c++1z -fvisibility-inlines-hidden -fPIC -m64 -pthread -O3 -fno-inline -Wall -g -fvisibility=hidden --target=x86_64-pc-linux -DBOOST_ALL_NO_LIB=1 -I"." -I".." -o "bin.v2/libs/sort/test/test_parallel_stable_sort.test/clang-linux-3.8/debug/cxxstd-1z-iso/optimization-speed/threading-multi/visibility-hidden/test_parallel_stable_sort.o" "libs/sort/test/test_parallel_stable_sort.cpp" |
|
Seems unrelated to this PR. I think it was caused by this commit, which added "this" in the lambda capture list. |
Free functions that are defined in header files must be qualified inline in order to avoid duplicate symbol errors at link time. Bugfix two cases: