NIP-76: Private Channels - Draft 2 - Includes Client Implementation and Tool kit library #116
Draft
d-krause wants to merge 42 commits intoblock-core:mainfrom
Draft
NIP-76: Private Channels - Draft 2 - Includes Client Implementation and Tool kit library #116d-krause wants to merge 42 commits intoblock-core:mainfrom
d-krause wants to merge 42 commits intoblock-core:mainfrom
Conversation
…menting out debugger line
… listen for events from the component or service where they are subscribed.
…ow done with brwoser subtle - so all relevant methods became async
…enting relay service from altering 17761 events
…ge from wallet core rules
…but messy version, clean up on the way
…nneeded fields, removing chain codes from the nprivatechan and FollowDocument
…e post document work into the model, hdkIndex keeps track of documents
…evel concept,changing ContentDocument serialization. getting ready for invitations and rsvps
…d storing invitations
…invitations and rsvps
…now revoke invitations
sondreb
requested changes
Apr 6, 2023
Member
sondreb
left a comment
There was a problem hiding this comment.
Great work, thanks for this PR! Please fix the nip-76 reference and I'll test it locally.
Member
|
This is all great work! Can this be adopted to also support extension and not private key in the app? The We can extend the Blockcore Wallet extension with additional features that might be needed to improve the private channel user experience. |
Author
Sure. I will look into this. I need about a week to make the necessary changes. |
…ng extension provider methods and adding interfaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
First Client Demo at https://nostr-nip76.web.app/private-channels
For those of you not familiar with blockcore-notes, just login with a private key (demo keys provided in the link), or create an entirely new profile. blockcore-notes prompts you for a password on each signing event. If you did not enter a password during account creation, just leave the password blank, and click OK.

Links