Refactor remaining field processing into dedicated processors#81
Merged
Refactor remaining field processing into dedicated processors#81
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors calendar event processing by extracting inline field processing logic into dedicated processor classes, improving code organization and maintainability. The main changes involve moving time field handling, recurrence field processing, and other event field processing logic into specialized processor classes.
- Extracts time field processing (DTSTART, DTEND, DURATION) into
TimeFieldsProcessor - Creates dedicated processors for recurrence fields and original instance time handling
- Refactors the main
LegacyAndroidEventProcessorto use the new processor architecture
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| TimeFieldsProcessor.kt | New processor handling DTSTART, DTEND, DURATION, and ALL_DAY field processing |
| OriginalInstanceTimeProcessor.kt | New processor for handling ORIGINAL_INSTANCE_TIME field processing |
| RecurrenceFieldsProcessor.kt | New processor for handling RRULE, RDATE, EXRULE, EXDATE fields |
| LegacyAndroidEventProcessor.kt | Refactored to use new processor architecture, removing inline field processing |
| RemindersProcessor.kt | Updated to use event title from entity instead of to.summary |
| AndroidEventFieldProcessor.kt | Added exception documentation |
| TimeFieldsBuilder.kt | Updated exception type from local to remote resource |
| AndroidEntityBuilder.kt | Added exception documentation |
| Various test files | New test files for the extracted processors and updated existing tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/processor/RemindersProcessor.kt
Show resolved
Hide resolved
sunkup
approved these changes
Sep 23, 2025
Member
sunkup
left a comment
There was a problem hiding this comment.
It already looks so much cleaner now: 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.