Merged
Conversation
# Conflicts: # lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/LegacyAndroidEventProcessor.kt # lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/processor/AndroidEventFieldProcessor.kt
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements calendar event processors as part of migrating from legacy event processing to a more modular processor-based architecture. The PR adds individual processor classes for different event fields and removes the corresponding logic from the legacy processor.
- Refactors event field processing from monolithic legacy code to individual specialized processors
- Adds comprehensive test coverage for the new processor classes
- Updates the LegacyAndroidEventProcessor to use the new processors and removes duplicate legacy code
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| AccessLevelProcessor.kt | Handles event classification and access level mapping with retained classification support |
| AvailabilityProcessor.kt | Processes event availability (opaque/transparent) from Android calendar data |
| CategoriesProcessor.kt | Extracts and processes event categories from extended properties |
| ColorProcessor.kt | Maps event colors from both color keys and RGB values |
| DescriptionProcessor.kt | Processes event description with null/blank handling |
| LocationProcessor.kt | Processes event location with trimming |
| MutatorsProcessor.kt | Handles event mutators for PRODID generation |
| OrganizerProcessor.kt | Processes organizer information for group-scheduled events |
| SequenceProcessor.kt | Handles event sequence numbers |
| StatusProcessor.kt | Maps Android event status to iCal status values |
| TitleProcessor.kt | Processes event titles with trimming |
| UnknownPropertiesProcessor.kt | Handles unknown/custom properties with exclusion logic |
| UrlProcessor.kt | Processes event URLs with validation |
| AndroidEventFieldProcessor.kt | Adds documentation comment to interface |
| LegacyAndroidEventProcessor.kt | Updates to use new processors and removes legacy processing code |
| *Test.kt files | Comprehensive unit tests for all new processor classes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...rc/main/kotlin/at/bitfire/synctools/mapping/calendar/processor/UnknownPropertiesProcessor.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/processor/OrganizerProcessor.kt
Show resolved
Hide resolved
lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/processor/ColorProcessor.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next-to-last bunch of event processors.
Still missing: time fields, recurring rules
@sunkup The next PR will then close #74 and finalize moving everything into processor classes.