Event processor: create processor interface#76
Conversation
763ddca to
c81479f
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the LegacyAndroidEventProcessor to improve code organization by extracting dedicated processor classes for specific event field processing tasks. The change delegates the handling of UIDs, attendees, and reminders to specialized processor classes while maintaining the same functionality.
Key changes:
- Extracted attendees, reminders, and UID processing into dedicated processor classes
- Created a common interface
AndroidEventFieldProcessorfor all field processors - Moved test methods for these processors to dedicated test classes
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| AndroidEventFieldProcessor.kt | Interface definition for event field processors |
| UidProcessor.kt | Dedicated processor for UID field handling |
| RemindersProcessor.kt | Dedicated processor for reminder/alarm field handling |
| AttendeesProcessor.kt | Dedicated processor for attendee field handling |
| UidProcessorTest.kt | Unit tests for UID processor functionality |
| RemindersProcessorTest.kt | Unit tests for reminders processor functionality |
| AttendeesProcessorTest.kt | Unit tests for attendees processor functionality |
| LegacyAndroidEventProcessor.kt | Refactored main processor using dedicated field processors |
| LegacyAndroidEventProcessorTest.kt | Updated integration tests with processor-specific tests removed |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/processor/RemindersProcessor.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/processor/AttendeesProcessor.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This pull request refactors the
LegacyAndroidEventProcessorand its associated tests to delegate the processing of certain event fields (UIDs, attendees, and reminders) to dedicated processor classes (similar to #64).Key changes include:
UidProcessor,AttendeesProcessor,RemindersProcessor).