Skip to content

Event processor: create processor interface#76

Merged
rfc2822 merged 7 commits intomainfrom
74-split-processor-into-field-processor-classes
Sep 22, 2025
Merged

Event processor: create processor interface#76
rfc2822 merged 7 commits intomainfrom
74-split-processor-into-field-processor-classes

Conversation

@rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Sep 19, 2025

This pull request refactors the LegacyAndroidEventProcessor and its associated tests to delegate the processing of certain event fields (UIDs, attendees, and reminders) to dedicated processor classes (similar to #64).

Key changes include:

  • Introduced new processor classes (UidProcessor, AttendeesProcessor, RemindersProcessor).
  • Removed direct processing of attendees, reminders, and UID from the main event population logic, relying instead on the new processors.

@rfc2822 rfc2822 self-assigned this Sep 19, 2025
@rfc2822 rfc2822 linked an issue Sep 19, 2025 that may be closed by this pull request
@rfc2822 rfc2822 added the refactoring Quality improvement of existing functions label Sep 19, 2025
@rfc2822 rfc2822 force-pushed the 74-split-processor-into-field-processor-classes branch from 763ddca to c81479f Compare September 19, 2025 11:52
@rfc2822 rfc2822 linked an issue Sep 19, 2025 that may be closed by this pull request
@rfc2822 rfc2822 linked an issue Sep 19, 2025 that may be closed by this pull request
@rfc2822 rfc2822 changed the title 74-split-processor-into-field-processor-classes Event processor: create processor interface Sep 19, 2025
@rfc2822 rfc2822 requested a review from Copilot September 19, 2025 12:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the LegacyAndroidEventProcessor to improve code organization by extracting dedicated processor classes for specific event field processing tasks. The change delegates the handling of UIDs, attendees, and reminders to specialized processor classes while maintaining the same functionality.

Key changes:

  • Extracted attendees, reminders, and UID processing into dedicated processor classes
  • Created a common interface AndroidEventFieldProcessor for all field processors
  • Moved test methods for these processors to dedicated test classes

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
AndroidEventFieldProcessor.kt Interface definition for event field processors
UidProcessor.kt Dedicated processor for UID field handling
RemindersProcessor.kt Dedicated processor for reminder/alarm field handling
AttendeesProcessor.kt Dedicated processor for attendee field handling
UidProcessorTest.kt Unit tests for UID processor functionality
RemindersProcessorTest.kt Unit tests for reminders processor functionality
AttendeesProcessorTest.kt Unit tests for attendees processor functionality
LegacyAndroidEventProcessor.kt Refactored main processor using dedicated field processors
LegacyAndroidEventProcessorTest.kt Updated integration tests with processor-specific tests removed

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rfc2822 rfc2822 marked this pull request as ready for review September 19, 2025 12:11
@rfc2822 rfc2822 requested a review from Copilot September 19, 2025 12:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rfc2822 rfc2822 marked this pull request as draft September 22, 2025 08:10
@rfc2822 rfc2822 marked this pull request as ready for review September 22, 2025 08:19
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rfc2822 rfc2822 merged commit 1de710c into main Sep 22, 2025
9 checks passed
@rfc2822 rfc2822 deleted the 74-split-processor-into-field-processor-classes branch September 22, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Quality improvement of existing functions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Processor interface

2 participants