Conversation
rfc2822
force-pushed
the
27-move-logic-from-androidcalendar-companion-object-to-androidcalendarstore
branch
2 times, most recently
from
91b2f38 to
31236a3
Compare
rfc2822
force-pushed
the
27-move-logic-from-androidcalendar-companion-object-to-androidcalendarstore
branch
from
31236a3 to
e448038
Compare
…droidcalendar-companion-object-to-androidcalendarstore
…-object-to-androidcalendarstore # Conflicts: # lib/src/androidTest/kotlin/at/bitfire/ical4android/impl/TestJtxCollection.kt # lib/src/androidTest/kotlin/at/bitfire/ical4android/util/MiscUtilsTest.kt # lib/src/androidTest/kotlin/at/bitfire/synctools/storage/calendar/AndroidCalendarTest.kt # lib/src/main/kotlin/at/bitfire/ical4android/AndroidCalendar.kt # lib/src/main/kotlin/at/bitfire/ical4android/AndroidEvent.kt # lib/src/main/kotlin/at/bitfire/vcard4android/AndroidAddressBook.kt
rfc2822
force-pushed
the
27-move-logic-from-androidcalendar-companion-object-to-androidcalendarstore
branch
from
e306550 to
583fc07
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extracts calendar creation and lookup logic into a dedicated AndroidCalendarProvider class and updates all callers (production code and tests) to use it. It also adjusts batch operation logging and modernizes minor enum and logging patterns.
- Introduce
AndroidCalendarProviderfor calendar CRUD operations - Refactor
AndroidEvent,InitCalendarProviderRuleand tests to use the new provider - Simplify batch‐operation logging and update
Css3Colorparsing and iteration
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| InitCalendarProviderRule.kt | Use AndroidCalendarProvider and instance property for account |
| CalendarBatchOperation.kt | Moved to storage.calendar package and adjusted imports |
| AndroidCalendarProvider.kt | New provider class implementing calendar CRUD methods |
| AndroidCalendar.kt (storage/calendar) | New storage model wrapping ContentProviderClient |
| BatchOperation.kt | Simplified commit logging to use list formatting |
| Css3Color.kt | Updated parsing to toColorInt(), replaced values() with entries |
| Task.kt | Added import of new Css3Color |
| JtxICalObject.kt | Added import of new Css3Color |
| Event.kt | Added import of new Css3Color |
| AndroidEvent.kt | Switched from provider to client, updated imports |
| CalendarBatchOperationTest.kt | Updated package and calendar contract references |
| AndroidCalendarTest.kt | Refactored to use AndroidCalendarProvider and client |
| TestCalendar.kt | Updated to use AndroidCalendarProvider |
| AndroidEventTest.kt | Refactored to use InitCalendarProviderRule.initialize() and client |
| LoggingTestRunner.kt | Removed default handlers before adding LogcatHandler |
| build.gradle.kts | Added Kotlin test dependency |
lib/src/main/kotlin/at/bitfire/synctools/storage/calendar/AndroidCalendarProvider.kt
Show resolved
Hide resolved
sunkup
reviewed
Jul 3, 2025
lib/src/androidTest/kotlin/at/bitfire/synctools/storage/calendar/AndroidCalendarTest.kt
Show resolved
Hide resolved
sunkup
reviewed
Jul 3, 2025
lib/src/main/kotlin/at/bitfire/synctools/storage/calendar/AndroidCalendarProvider.kt
Show resolved
Hide resolved
lib/src/main/kotlin/at/bitfire/synctools/storage/calendar/AndroidCalendarProvider.kt
Show resolved
Hide resolved
lib/src/main/kotlin/at/bitfire/synctools/storage/calendar/AndroidCalendarProvider.kt
Show resolved
Hide resolved
rfc2822
deleted the
27-move-logic-from-androidcalendar-companion-object-to-androidcalendarstore
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for bitfireAT/davx5-ose#1560