DmfsTaskList/DmfsTask: provide all fields for DAVx5#138
Merged
Conversation
sunkup
force-pushed
the
dmfstasklist-features
branch
from
b03dbe3 to
04b34c8
Compare
sunkup
changed the title
sunkup
changed the title
5 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves task synchronization functionality from DAVx5 to the ical4android library by making DmfsTaskList and DmfsTask classes less abstract and providing all necessary fields for DAVx5 integration. The changes eliminate the need for DAVx5 to override populate* and build* methods.
Key changes:
- Changed
DmfsTaskListandDmfsTaskfrom abstract to open classes - Added sync-related fields (
syncId,eTag,flags,accessLevel) and methods (readSyncState,writeSyncState) - Changed
populate*andbuild*methods from protected/open to protected/private to prevent overriding
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
lib/src/main/kotlin/at/bitfire/ical4android/DmfsTaskList.kt |
Added accessLevel field, readSyncState/writeSyncState methods; changed class from abstract to open; made populate method private |
lib/src/main/kotlin/at/bitfire/ical4android/DmfsTask.kt |
Added syncId, eTag, flags fields; updated constructors to accept sync-related parameters; changed class from abstract to open; made internal methods private/protected |
lib/src/androidTest/kotlin/at/bitfire/ical4android/impl/TestTask.kt |
Updated constructor call to pass new required parameters (syncId, eTag, scheduleTag, flags) |
lib/src/androidTest/kotlin/at/bitfire/ical4android/DmfsTaskTest.kt |
Added test case to verify the new ContentValues constructor correctly populates fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ArnyminerZ
requested changes
Nov 17, 2025
lib/src/androidTest/kotlin/at/bitfire/ical4android/impl/TestTask.kt
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lib/src/androidTest/kotlin/at/bitfire/ical4android/impl/TestTask.kt
Outdated
Show resolved
Hide resolved
rfc2822
reviewed
Nov 25, 2025
sunkup
force-pushed
the
dmfstasklist-features
branch
from
060abe3 to
99102c6
Compare
rfc2822
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #116 (not closing)
Moves functionality from DAVx5
LocalTaskListandLocalTaskto the library so that there's no need to overridepopulate…andbuild…anymore.To be combined with bitfireAT/davx5-ose#1811