Conversation
…rocessor, EndTimeProcessor, and DurationProcessor
|
This PR/issue depends on: |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the EventValidator class and redistributes its functionality to more appropriate locations within the codebase. The alignment logic for RRULE UNTIL dates now resides in RecurrenceFieldsProcessor, where it's applied during event processing rather than as a separate validation step.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/src/main/kotlin/at/bitfire/ical4android/validation/EventValidator.kt | Removed entire EventValidator class |
| lib/src/test/kotlin/at/bitfire/ical4android/validation/EventValidatorTest.kt | Removed test file for deleted EventValidator |
| lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/processor/RecurrenceFieldsProcessor.kt | Added alignUntil method to handle RRULE UNTIL alignment |
| lib/src/test/kotlin/at/bitfire/synctools/mapping/calendar/processor/RecurrenceFieldProcessorTest.kt | Added test coverage for new alignUntil method |
| lib/src/main/kotlin/at/bitfire/ical4android/EventWriter.kt | Removed EventValidator.repair() call |
| lib/src/main/kotlin/at/bitfire/ical4android/EventReader.kt | Removed EventValidator.repair() call |
| lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/builder/EndTimeBuilder.kt | Added cross-reference comment to RecurrenceFieldsProcessor.alignUntil |
| lib/src/main/kotlin/at/bitfire/synctools/util/AndroidTimeUtils.kt | Improved documentation formatting with markdown code formatting |
| lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/processor/DurationProcessor.kt | Fixed toIcal4jDateTime call to include tzRegistry parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
EventValidatorand moves remaining functionality to where it belongs.Should clear the way for #82.
Closes #88. Depends on #102.