Skip to content

Remove EventValidator#107

Merged
rfc2822 merged 11 commits intomainfrom
remove-eventvalidator
Oct 18, 2025
Merged

Remove EventValidator#107
rfc2822 merged 11 commits intomainfrom
remove-eventvalidator

Conversation

@rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Oct 15, 2025

Removes EventValidator and moves remaining functionality to where it belongs.

Should clear the way for #82.

Closes #88. Depends on #102.

@rfc2822 rfc2822 self-assigned this Oct 15, 2025
@rfc2822 rfc2822 added the refactoring Quality improvement of existing functions label Oct 15, 2025
@rfc2822 rfc2822 changed the base branch from main to split-timefields-processor October 15, 2025 13:55
@github-actions
Copy link

This PR/issue depends on:

@rfc2822 rfc2822 changed the title remove-eventvalidator Remove EventValidator Oct 15, 2025
Base automatically changed from split-timefields-processor to main October 15, 2025 17:18
@rfc2822 rfc2822 marked this pull request as ready for review October 18, 2025 10:42
@rfc2822 rfc2822 requested a review from a team as a code owner October 18, 2025 10:42
@rfc2822 rfc2822 requested a review from Copilot October 18, 2025 10:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the EventValidator class and redistributes its functionality to more appropriate locations within the codebase. The alignment logic for RRULE UNTIL dates now resides in RecurrenceFieldsProcessor, where it's applied during event processing rather than as a separate validation step.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/src/main/kotlin/at/bitfire/ical4android/validation/EventValidator.kt Removed entire EventValidator class
lib/src/test/kotlin/at/bitfire/ical4android/validation/EventValidatorTest.kt Removed test file for deleted EventValidator
lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/processor/RecurrenceFieldsProcessor.kt Added alignUntil method to handle RRULE UNTIL alignment
lib/src/test/kotlin/at/bitfire/synctools/mapping/calendar/processor/RecurrenceFieldProcessorTest.kt Added test coverage for new alignUntil method
lib/src/main/kotlin/at/bitfire/ical4android/EventWriter.kt Removed EventValidator.repair() call
lib/src/main/kotlin/at/bitfire/ical4android/EventReader.kt Removed EventValidator.repair() call
lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/builder/EndTimeBuilder.kt Added cross-reference comment to RecurrenceFieldsProcessor.alignUntil
lib/src/main/kotlin/at/bitfire/synctools/util/AndroidTimeUtils.kt Improved documentation formatting with markdown code formatting
lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/processor/DurationProcessor.kt Fixed toIcal4jDateTime call to include tzRegistry parameter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rfc2822 rfc2822 merged commit 5ff8e41 into main Oct 18, 2025
10 checks passed
@rfc2822 rfc2822 deleted the remove-eventvalidator branch October 18, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Quality improvement of existing functions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop EventValidator

1 participant