This repository was archived by the owner on Jun 9, 2025. It is now read-only.
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a crash caused by attempting to read from an empty cursor and improves the clarity and robustness of the cursor-handling and organizer assignment logic.
- Improved cursor reading by checking moveToNext() and using getColumnIndexOrThrow.
- Removed a redundant condition for the organizer and updated catch clause syntax.
- Applied minor linting updates.
ArnyminerZ
suggested changes
May 13, 2025
ArnyminerZ
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
Getting
Error: android.database.CursorIndexOutOfBoundsException: Index 0 requested, with a size of 0atical4android/lib/src/main/kotlin/at/bitfire/ical4android/AndroidEvent.kt
Line 707 in 21622fe
Changes