refactor: Signal-slot connections cleanup#333
Merged
hebasto merged 3 commits intobitcoin-core:masterfrom Jun 12, 2021
Merged
Conversation
Member
Author
|
@promag @ryanofsky @Sjors @Talkless Could you look into this PR, please? |
This change makes a connection directly to the signal that was emitted in the removed slot. This commit does not change behavior.
This change makes a connection directly to the signal that was emitted in the removed slot. This commit does not change behavior.
This change removes redundant intermediate WalletFrame connections. This commit does not change behavior.
promag
reviewed
Jun 11, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 13, 2021
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
WalletView::outOfSyncWarningClickedsignal to theBitcoinGUI::showModalOverlayslot directly, and removes intermediateWalletFrameslot and signalThis PR does not change behavior.