This repository was archived by the owner on Jun 5, 2023. It is now read-only.
Don't send extra data when getting the next delayed timestamp #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only the first item in that list is ever used
|
👍 |
binarymatt
added a commit
that referenced
this pull request
Oct 28, 2013
Don't send extra data when getting the next delayed timestamp
Owner
|
thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a problem where the scheduler stopped for a while so the delayed jobs started backing up. When the scheduler came back up each call to get_next_timestamp was returning the full set of timestamps, which became huge. I was burning through the backlog at a rate of only a couple of jobs per second; after applying this patch that jumped to a couple hundred.