Fix for 'not yet supported' error when packing classes#13
Closed
RealHandy wants to merge 1 commit intobinaryjs:masterfrom
Closed
Fix for 'not yet supported' error when packing classes#13RealHandy wants to merge 1 commit intobinaryjs:masterfrom
RealHandy wants to merge 1 commit intobinaryjs:masterfrom
Conversation
This was referenced May 28, 2019
afrokick
added a commit
to peers/js-binarypack
that referenced
this pull request
Jul 9, 2019
afrokick
added a commit
to peers/js-binarypack
that referenced
this pull request
Aug 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New class behaviors in recent javascript cause a 'type is not yet supported' error when packing instances of class objects that have a constructor that returns class ClassName instead of Object.
This fixes (or works around) it by getting a toString() of what the constructor is and seeing if it starts with 'class'.