Skip to content

[4] Version control change after release note deletion #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnmunster merged 6 commits into from
Jan 10, 2024
Merged

[4] Version control change after release note deletion #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
78b23e4
add: New test that varifies that is possible to delete release notes:
Dec 11, 2023
3eb8c60
fix: adjusted the selector in the test to grab the most recent releas…
Dec 12, 2023
04eab16
fix: added an extra assertion to the version in the top toolbar and c…
Dec 13, 2023
24831b2
test: refactored the test to make it more about the version control t…
Jan 10, 2024
3dff58c
Merge branch 'main' into feature/delete-release-note
johnmunster Jan 10, 2024
bbdffe9
test: filename, test description and slight refactor of code so that …
Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions cypress/e2e/release-note-version-control.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
/// <reference types="cypress" />

describe('release notes version control', () => {
before(() => {
cy.visit('/wp-admin/edit.php?post_type=release-note');
});

it('should change the version accordingly after a release note has been deleted', () => {
//asserts that the version number is the current version
cy.get('#wpadminbar').within(() => {
cy.get('#wp-admin-bar-release-note-version > a').should('contain', 'Version 1.6.0');
})
//deletes the current release note in the post list
cy.get('#the-list').within(() => {
cy.get('#post-5 .row-actions').invoke('attr', 'style', 'position: static').find('.submitdelete').click();
cy.visit('/wp-admin/edit.php?post_type=release-note');
cy.get('tr').should('have.length', 1);
});
//asserts that the version number has changed to the previous release note version
cy.get('#wpadminbar').within(() => {
cy.get('#wp-admin-bar-release-note-version > a').should('contain', 'Version 1.5.0');
}) });
});
80 changes: 79 additions & 1 deletion cypress/seeds/ReleaseNoteSeeder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,89 @@
use WP_Cypress\Seeder\Seeder;
use WP_Cypress\Fixtures;


class ReleaseNoteSeeder extends Seeder {
public function run() {
$release_note_template = '<!-- wp:heading -->
<h2 class="wp-block-heading">Overview</h2>
<!-- /wp:heading -->
<!-- wp:paragraph -->
<p> %s </p>
<!-- /wp:paragraph -->
<!-- wp:heading -->
<h2 class="wp-block-heading">Added</h2>
<!-- /wp:heading -->
<!-- wp:list -->
<ul><!-- wp:list-item -->
<li> %s </li>
<!-- /wp:list-item -->
<!-- wp:list-item -->
<li> %s </li>
<!-- /wp:list-item --></ul>
<!-- /wp:list -->
<!-- wp:heading -->
<h2 class="wp-block-heading">Changed</h2>
<!-- /wp:heading -->
<!-- wp:list -->
<ul><!-- wp:list-item -->
<li> %s </li>
<!-- /wp:list-item -->
<!-- wp:list-item -->
<li> %s </li>
<!-- /wp:list-item --></ul>
<!-- /wp:list -->
<!-- wp:heading -->
<h2 class="wp-block-heading">Fixed</h2>
<!-- /wp:heading -->
<!-- wp:list -->
<ul><!-- wp:list-item -->
<li> %s </li>
<!-- /wp:list-item -->
<!-- wp:list-item -->
<li> %s </li>
<!-- /wp:list-item --></ul>
<!-- /wp:list -->';

( new Fixtures\Post([
'post_type' => 'release-note',
'post_date' => date("Y-m-d H:i:s", strtotime("Nov 10, 2023 15:01:10")),
'post_content' => sprintf(
$release_note_template,
$this->faker->realText( 100 ),
$this->faker->realText( 40 ),
$this->faker->realText( 40 ),
$this->faker->realText( 40 ),
$this->faker->realText( 40 ),
$this->faker->realText( 40 ),
$this->faker->realText( 40 ),
'1.5.0'
),
'post_meta' => [
'version' => '1.5.0',
'release_date' => date("Y-m-d", strtotime("Nov 10, 2023")),
]
]))->create(1);

( new Fixtures\Post([
'post_type' => 'release-note',
]) )->create(10);
'post_date' => date("Y-m-d H:i:s", strtotime("Dec 04, 2023 14:22:32")),
'post_content' => sprintf(
$release_note_template,
$this->faker->realText( 100 ),
$this->faker->realText( 40 ),
$this->faker->realText( 40 ),
$this->faker->realText( 40 ),
$this->faker->realText( 40 ),
$this->faker->realText( 40 ),
$this->faker->realText( 40 ),
'1.6.0'
),
'post_meta' => [
'version' => '1.6.0',
'release_date' => date("Y-m-d", strtotime("Dec 04, 2023")),
],

]))->create(1);
}
}

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"watch:dev:all": "webpack --mode=development --watch --env=\"all-projects\"",
"watch:prod": "webpack --mode=production --watch --env=\"project=$npm_config_project\"",
"watch:prod:all": "webpack --mode=production --watch --env=\"all-projects\"",
"test:e2e": "wp-cypress start"
"test:e2e": "wp-cypress stop && wp-cypress start && cypress open"
},
"dependencies": {
"@bigbite/build-tools": "git+ssh://[email protected]:bigbite/build-tools.git#1.0.0-beta.6",
Expand Down