Add TS 1.5 Features #691
Merged
Add TS 1.5 Features #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srgg
reviewed
Dec 12, 2016
| String s = new String(v.binaryValue(), StandardCharsets.UTF_8); | ||
| return new Cell(s); | ||
| final OtpErlangBinary v = (OtpErlangBinary) cell; | ||
| if (columnDescriptions.get(j).getType() == RiakTsPB.TsColumnType.VARCHAR) |
Contributor
There was a problem hiding this comment.
IMO better to throw exception in case when something is incompatible, rather then silently skip it:
switch(columnDescriptions.get(j).getType()){
case RiakTsPB.TsColumnType.VARCHAR://
case RiakTsPB.TsColumnType.BLOB: //
default:
throw new IllegalStateException(<proper explanation>)
}
Contributor
Author
There was a problem hiding this comment.
We do fall through to the "default" case on line 367 / 368 where we throw an exception, but I guess it could be more specific.
srgg
reviewed
Dec 12, 2016
|
|
||
| if (lk.hasKeyOrder()) | ||
| { | ||
| sb.append(" "); |
Contributor
There was a problem hiding this comment.
Might be (but not mandatory) re-written like:
sb.append(" ")
.append(lk.getKeyOrder().toString());
…client into ts-1.5-features
…ake error be more informative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Blob data type and support for the ever-expanding DESCRIBE table result.
Description
Adds support for the new BLOB TS data type, and accepts another column for the DESCRIBE table result.
Related Issue
https://bashoeng.atlassian.net/browse/CLIENTS-935
Motivation and Context
To implement all the things!
How Has This Been Tested?
Tests run fine against TS 1.5 RC2.
Types of changes
Checklist:
Pull requests that are small and limited in scope are most welcome.