Ready: Fix BinaryValue json encoding for MapReduce inputs #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@alexmoore why don't us get rid of BinaryValue as we did for TS? |
| /** | ||
| * Serializes a {@link BinaryValue} to a UTF-8 string for the Riak MapReduce JSON format. | ||
| */ | ||
| public class BinaryValueSerializer extends JsonSerializer<BinaryValue> |
Contributor
There was a problem hiding this comment.
Should it be registered somehow to be used by default without a necessity to be registered explicitly by user?
UPD:
Found that it is registered in MapReduce.writeSpec, but what about pulling all JsonGenerator creation related stuff into separate static function that will be reused in the Tests?
alexmoore
changed the title
|
👍 Tests pass, the code looks reasonable but I am having a hard time following the changes. :( |
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #520 (CLIENTS-413).