Skip to content

[RFC] Bump deps#31

Closed
lucafavatella wants to merge 4 commits intobasho:developfrom
lucafavatella:bump-deps
Closed

[RFC] Bump deps#31
lucafavatella wants to merge 4 commits intobasho:developfrom
lucafavatella:bump-deps

Conversation

@lucafavatella
Copy link
Copy Markdown

No description provided.

@lucafavatella
Copy link
Copy Markdown
Author

rebar 2 on CI fails with something like:

Pulling syslog from {git,"https://github.com/Vagabond/erlang-syslog.git",

                         {ref,"0e4f0e95c361af298c5d1d17ceccfa831efc036d"}}

Cloning into 'syslog'...

ERROR: 'get-deps' failed while processing /home/travis/build/lucafavatella/lager_syslog: {'EXIT',{badarg,[{io_lib,format,

                         ["git checkout -q ~s",

                          [{ref,"0e4f0e95c361af298c5d1d17ceccfa831efc036d"}]],

                         [{file,"io_lib.erl"},{line,168}]},

                 {rebar_deps,download_source,2,[]},

                 {rebar_deps,use_source,3,[]},

                 {rebar_deps,'-get-deps/2-fun-0-',2,[]},

                 {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},

                 {rebar_deps,'get-deps',2,[]},

                 {rebar_core,run_modules,4,[]},

                 {rebar_core,execute,6,[]}]}}

@lucafavatella lucafavatella changed the title [WIP] Bump deps [RFC] Bump deps Apr 7, 2017
@lucafavatella
Copy link
Copy Markdown
Author

Not sure syslog dep supports rebar 2 any longer - maybe it is supported on a best effort basis and not tested on CI.

@lucafavatella
Copy link
Copy Markdown
Author

Apparently the problem is not the syslog dep but the way the syslog dep is expressed. As I attempted to refer to specific commit, the syntax is incompatible between rebar3 and 2:

rebar 2 https://github.com/rebar/rebar/wiki/Dependency-management#example

    % {mochiweb, "2.3.2", {git, "https://github.com/mochi/mochiweb.git", "15bc558d8222b011e2588efbd86c01d68ad73e60"},

rebar3 http://www.rebar3.org/docs/dependencies#section-declaring-dependencies
requires {ref, _} tuple around commit string.

@lucafavatella
Copy link
Copy Markdown
Author

I expect CI tests to pass for both rebar 2 and 3 now. Once syslog is tagged (see also #29 (comment)) the rebar 2 sed hack in the CI script can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant