[RFC] Bump deps#31
Closed
lucafavatella wants to merge 4 commits intobasho:developfrom
lucafavatella:bump-deps
Closed
[RFC] Bump deps#31lucafavatella wants to merge 4 commits intobasho:developfrom lucafavatella:bump-deps
lucafavatella wants to merge 4 commits intobasho:developfrom
lucafavatella:bump-deps
Conversation
Author
|
rebar 2 on CI fails with something like: |
Author
|
Not sure syslog dep supports rebar 2 any longer - maybe it is supported on a best effort basis and not tested on CI. |
Author
|
Apparently the problem is not the syslog dep but the way the syslog dep is expressed. As I attempted to refer to specific commit, the syntax is incompatible between rebar3 and 2: rebar 2 https://github.com/rebar/rebar/wiki/Dependency-management#example rebar3 http://www.rebar3.org/docs/dependencies#section-declaring-dependencies |
Author
|
I expect CI tests to pass for both rebar 2 and 3 now. Once syslog is tagged (see also #29 (comment)) the rebar 2 sed hack in the CI script can be removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.